Changelog

New linters:

• expect_s3_class_linter() (@trevorld, #110)
• expect_s4_class_linter() (@trevorld, #109)
• nzchar_linter() (@trevorld, #102)
• vector_logic_linter() (@trevorld, #111)

New vignette “Tips and tricks” that lists some solutions for problems one may encounter when writing new rules (#94).

When using external rules with the with-<pkg> syntax, if the YAML file contains several rules separated by “—”, then flir would only use the first one. This is now fixed (#95).

list_linters() now uses path = "." by default (#99).

add_new_rule() now errors if the file already exists (#87).

In all functions that create or modify files (fix(), setup_flir(), etc.), the argument path has to be specified. Linting functions keep using the default path ".". This is due to the CRAN policy that a package cannot modify the user file system (#79).

Most fix_*() functions have a new argument interactive (FALSE by default). When set to TRUE, it opens a Shiny app in the Viewer so that the user can review fixes that would be applied to a file. It is therefore possible to accept or skip fixes on a file-by-file basis (#76).

In R packages, it is now possible to create a list of rules that will be available to the users of the package. This can be useful to provide automatic fixes for deprecated or superseded functions, for example. More information is available in the vignette “Sharing rules across packages”. Thanks to @maelle and @Bisaloo for the suggestion and early feedback on the implementation (#78, #84).

add_new_rule() now accepts several names at once (#88).

unreachable_code is deactivated by default. It can still be activated with the argument linters or in flir/config.yml after running setup_flir() (#75).

T_and_F_symbol do not detect anymore the use of F and T when those are used in the : operation (#81).

semicolon_linter is no longer used. It is a linter related to code formatting only and therefore isn’t in the scope of flir (and the current implementation was buggy). It is also handled by the Air formatter (#93).

Changes were still directly applied to files that are unstaged in Git while there should have been a warning. This is now fixed.

Properly skip changes in the user picks “No” in the menu about modifying unstaged files in Git.

No longer error about unavailable sourceMarkers when running lint() in Positron.

Better detection of flint/config.yml when using running flint on a package or a directory.

The cache used after setup_flir() is now invalidated if the rules used change.

Do not print “empty data.table(…)” when no lints are detected.

New linter stopifnot_all_linter() to detect calls to stopifnot(all(...)) since the all() is unnecessary. This has an automatic fix available.

New linter list_comparison_linter() to detect a comparison with a list, e.g. lapply(x, sum) > 10. No automatic fix available.

Line breaks are removed from multi-line messages reported by lint* functions.

matrix_apply_linter now detects when 1L and 2L are used in the MARGIN argument.

any_is_na_linter now reports cases like NA %in% x, and can fix them to be anyNA(x) instead.

library_call_linter no longer reports cases where library() calls are wrapped in suppressPackageStartupMessages().

Nested fixes no longer overlap. The fix*() functions now run several times on the files containing nested fixes until there are no more fixes to apply. This can be deactivated to run only once per file by adding rerun = FALSE (#61).

any_is_na_linter wrongly reported cases like any(is.na(x), y). Those are no longer reported.

No longer lint and fix expect_equal(length(x), length(y)), which is more readable than expect_length(x, length(y)).

No longer lint and fix expect_equal(names(x), names(y)), which is more readable than expect_named(x, names(y)).

Rule names have been harmonized to use a dash instead of underscore, e.g. any_duplicated-1 instead of any_duplicated_1.

Replacement of redundant_ifelse_linter of the form ifelse(cond, FALSE, TRUE) now works (#57).

absolute_path_linter was deactivated in 0.0.5 but was still reported. It is now properly ignored.

Code like expect_equal(typeof(x), 'class') was modified twice by expect_identical_linter and expect_type_linter, which lead to a wrong rewrite. It is now replaced by expect_type(x, 'class').

fix() and lint() now work correctly when several paths are passed.

fix_package() and lint_package() used all R files present from the root path, even those in folders that are not typical of an R package.

fix_dir() and fix_package() now have the arguments force and verbose, like fix().

New linters: expect_named, numeric_leading_zero, outer_negation, redundant_ifelse, undesirable_function, unreachable_code.

fix_dir(), fix_package(), lint_dir(), lint_package() now have arguments to exclude paths, linters, and use cache.

Removed browser linter (it is now part of undesriable_function).

Add support for a flint/config.yml file that contains the list of linters to use so that one doesn’t need to constantly specify them in lint() or fix().